Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in profiling code and create profiling CI #346

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Fix bug in profiling code and create profiling CI #346

merged 3 commits into from
Nov 5, 2024

Conversation

MarionBWeinzierl
Copy link
Collaborator

@MarionBWeinzierl MarionBWeinzierl commented Nov 1, 2024 •
edited
Loading

Description

Fixes #345

This corrects the signature in PModel in the profiling code, and creates a new Github Action that just runs the profiling without the benchmarking, to avoid code rot in future.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

@MarionBWeinzierl MarionBWeinzierl self-assigned this Nov 1, 2024
@MarionBWeinzierl MarionBWeinzierl linked an issue Nov 1, 2024 that may be closed by this pull request
Fix PModel Signature Mismatch in Profiling and Create Quick CI Action #345
Closed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (1f315ba) to head (37e80d1).
Report is 438 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #346      +/-   ##
===========================================
+ Coverage    95.29%   95.34%   +0.05%     
===========================================
  Files           28       35       +7     
  Lines         1720     2751    +1031     
===========================================
+ Hits          1639     2623     +984     
- Misses          81      128      +47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

davidorme
davidorme approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarionBWeinzierl MarionBWeinzierl merged commit d9c3b51 into develop Nov 5, 2024
24 checks passed
@MarionBWeinzierl MarionBWeinzierl deleted the issue345-profiling-bugfix-and-ci branch November 5, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidorme davidorme davidorme approved these changes

@j-emberton j-emberton Awaiting requested review from j-emberton

Assignees

@MarionBWeinzierl MarionBWeinzierl

Labels
None yet
Projects
ICCS development board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix PModel Signature Mismatch in Profiling and Create Quick CI Action
3 participants
@MarionBWeinzierl @codecov-commenter @davidorme